Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the client code #503

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Refactor the client code #503

merged 1 commit into from
Jan 10, 2022

Conversation

mkumatag
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #376

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2022
@netlify
Copy link

netlify bot commented Jan 10, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

🔨 Explore the source changes: 119d45c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/61dbedab74610f0008fc2ce2

😎 Browse the preview: https://deploy-preview-503--kubernetes-sigs-cluster-api-ibmcloud.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@mkumatag
Copy link
Member Author

/cc @Karthik-K-N

wentao-zh
wentao-zh approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@wentao-zh wentao-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, wentao-zh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit fbf1313 into kubernetes-sigs:main Jan 10, 2022
@mkumatag mkumatag deleted the refactor_client branch January 10, 2022 09:52
@mkumatag
Copy link
Member Author

@Prajyot-Parab you may need to refactor your code to use the this new code
@Amulyam24 now you can mock the ibm cloud clients and add more unit tests

@mkumatag mkumatag mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wentao-zh wentao-zh wentao-zh approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@wentao-zh wentao-zh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code refactoring of clients for better mocking
3 participants
@mkumatag @k8s-ci-robot @wentao-zh